-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new rule: padding-lines-between-tags #3554 #3789
base: master
Are you sure you want to change the base?
Conversation
padding-lines-between-tags
: add rule and test cases
@ljharb Let me know your thoughts. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3789 +/- ##
==========================================
- Coverage 97.75% 97.19% -0.57%
==========================================
Files 135 136 +1
Lines 9715 9789 +74
Branches 3527 3553 +26
==========================================
+ Hits 9497 9514 +17
- Misses 218 275 +57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes, but in particular, it would need thorough tests.
#3554 Rule to disallow blank lines between tags
Based on https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/padding-line-between-tags.js