feat: remove dependencies for Node built-ins #3847
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
force-pushed
the
remove-dependencies-for-Node-built-ins
branch
from
dfc67fc
to
8df94e9
Compare
BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0
MichaelDeBoey
force-pushed
the
remove-dependencies-for-Node-built-ins
branch
from
8df94e9
to
952181e
Compare
MichaelDeBoey
force-pushed
the
remove-dependencies-for-Node-built-ins
branch
from
952181e
to
8fab926
Compare
MichaelDeBoey
commented
Oct 30, 2024
| @@ -29,24 +29,15 @@ | |||
| "homepage": "https://github.com/jsx-eslint/eslint-plugin-react", | |||
| "bugs": "https://github.com/jsx-eslint/eslint-plugin-react/issues", | |||
| "dependencies": { | |||
| "array-includes": "^3.1.8", | |||
| "array.prototype.findlast": "^1.2.5", | |||
| "array.prototype.flatmap": "^1.3.2", | |||
| "array.prototype.tosorted": "^1.1.4", | |||
There was a problem hiding this comment.
Unfortunately array.prototype.toSorted is only available as of Node v20 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.