Fix jsx-sort-prop-types issue with custom propTypes #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickcr
added a commit
that referenced
this pull request
Jan 24, 2016
Fix jsx-sort-prop-types issue with custom propTypes (fixes #408)
|
Thanks. I'll make some additional tests for complex propTypes but for now it should fix the crash. |
|
Thanks 😁 |
|
@alitaheri Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #408
caveats:
Might not behave correctly with complex propTypes when the are
requiredalthough this was a problem with the original PR ( #392 ). But it might be fixed here too. I simply don't know how 😁