Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jsx-uses-vars rule to WARN by default #51

Merged
merged 1 commit into from
Apr 6, 2015
Merged

Enable jsx-uses-vars rule to WARN by default #51

merged 1 commit into from
Apr 6, 2015

Conversation

banderson
Copy link
Contributor

From original issue: "just wondering why jsx-uses-vars wouldn't be turned on by default (maybe to 'warn')? I guess the real question is: what's the use case for not wanting to mark them used?"

Fixes #49

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.73% when pulling d0d998b on banderson:enable-jsx-uses-vars-by-default into ac42603 on yannickcr:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.73% when pulling d0d998b on banderson:enable-jsx-uses-vars-by-default into ac42603 on yannickcr:master.

yannickcr added a commit that referenced this pull request Apr 6, 2015
Enable jsx-uses-vars rule to WARN by default
@yannickcr yannickcr merged commit 62ba591 into jsx-eslint:master Apr 6, 2015
@yannickcr
Copy link
Member

Thanks!

@banderson banderson deleted the enable-jsx-uses-vars-by-default branch April 7, 2015 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Rule 'jsx-uses-vars': why not on by default?
3 participants