propName should always return a value #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebeach
force-pushed
the
propName--return-value-should-not-be-nullable
branch
from
33e581a to
f520208
Compare
jessebeach
force-pushed
the
propName--return-value-should-not-be-nullable
branch
from
7e29e3c to
e89722b
Compare
|
Ya, the coverage fall is fine. I removed a test that doesn't test anything. |
beefancohen
reviewed
Jul 6, 2017
| } | ||
|
|
||
| return prop.name.name; |
There was a problem hiding this comment.
This could cause upstream failures if prop.name is undefined. Do we want to keep the switch statement and return an empty string, or do you think it's ok for an error to be thrown (i'm indifferent, its an edge case)
There was a problem hiding this comment.
I'm in agreement with @ljharb here. A JSXAttribute without a name seems very unlikely.
There was a problem hiding this comment.
If it can exist, then we should have a test case for it. Lacking one, we shouldn't expect it to exist :-)
beefancohen
approved these changes
Jul 7, 2017
ljharb
approved these changes
Jul 7, 2017
|
@evcohen I don't have write access to this repo. Merge is all yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the return value of
propNameis nullable. It should be able to guarantee a return value all the time.