Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flag --namespace-iam-role-key and the ability to request a role at the namespace level #250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vladiacob
Copy link

The possibility to assign a specific role at the namespace level.
A new flag to specify under which annotation the iam role is present at the namespace level.

@coveralls
Copy link

coveralls commented Dec 30, 2019

Coverage Status

Coverage increased (+1.4%) to 20.874% when pulling f6a2687 on vladiacob:role-on-namespace-level into 47b54eb on jtblin:master.

@@ -29,3 +29,4 @@ _testmain.go
/build/
coverage.out
/vendor/
.idea
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best use a global .gitignore for that

@@ -47,14 +48,24 @@ func (r *RoleMapper) GetRoleMapping(IP string) (*RoleMappingResult, error) {
return nil, err
}

namespace := pod.GetNamespace()
Copy link

@grosser grosser Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to make this have 0 overhead for everyone else, how about it only fetches the namespace when the flag is enabled ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants