Incorrect ip to namespace table for pods in a failed state. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These pods finish running in a Complete or Failed state and linger for sometime. Unfortunately kubernetes leaves the PodIP intact that was used for these pods. If docker reuses these ips then we have a conflict and this leads to ips being flagged against the wrong namespace. This change restricts the namespace tracking to pods in a Running phase. This might not be a complete solution to this issue.
|
Changes Unknown when pulling cf7e76e on corlettb:master into ** on jtblin:master**. |
|
I think I might be seeing this even with cronjob pods that aren't failed but completed. I'm going to evaluate this as a possible solution. |
|
@SleepyBrett That does happen. We have a working set that changes the indexing pattern that is build with the We have been running it for several weeks now without these issues. |
|
#92 is now released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run a number of cronjobs in our environment.
These pods finish running in a Complete or Failed state and linger for sometime. Unfortunately kubernetes leaves the PodIP intact that was used for these pods.
If docker reuses these ips then we have a conflict and this leads to ips being flagged against the wrong namespace. This breaks the restricted namespace functionality.
This change restricts the namespace tracking to pods in a Running phase.
This might not be a complete solution to this issue but maybe it can start a dialogue.