chore: add more strct linting to generated projects

jtdLab · Aug 25, 2023 · e3ae480 · e3ae480
1 parent 9593f4b
commit e3ae480
Show file tree

Hide file tree

Showing 144 changed files with 1,164 additions and 1,014 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -56,6 +56,7 @@ linter:
     - camel_case_extensions
     - camel_case_types
     - cancel_subscriptions
+    #    - cascade_invocations TODO good in source bad in test code
     - cast_nullable_to_non_nullable
     - collection_methods_unrelated_type
     - combinators_ordering

diff --git a/bricks/bloc/__brick__/lib/src/application/{{{output_dir}}}/{{name.snakeCase()}}_bloc.dart b/bricks/bloc/__brick__/lib/src/application/{{{output_dir}}}/{{name.snakeCase()}}_bloc.dart
@@ -16,9 +16,7 @@ class {{name.pascalCase()}}Bloc extends Bloc<{{name.pascalCase()}}Event, {{name.
           const {{name.pascalCase()}}Initial(),
         ) {
     // Register handlers
-    on<{{name.pascalCase()}}Started>(
-      (event, emit) => _onStarted(event, emit),
-    );
+    on<{{name.pascalCase()}}Started>(_onStarted);
   }
 
   /// Handle incoming [{{name.pascalCase()}}Started] event.

diff --git a/...a_transfer_object/__brick__/lib/src/{{{output_dir}}}/{{entity_name.snakeCase()}}_dto.dart b/...a_transfer_object/__brick__/lib/src/{{{output_dir}}}/{{entity_name.snakeCase()}}_dto.dart
@@ -11,20 +11,20 @@ class {{entity_name.pascalCase()}}Dto with _${{entity_name.pascalCase()}}Dto {
     // TODO: add more fields here
   }) = _{{entity_name.pascalCase()}}Dto;
 
-  const {{entity_name.pascalCase()}}Dto._();
-
   factory {{entity_name.pascalCase()}}Dto.fromDomain({{entity_name.pascalCase()}} domain) {
     return {{entity_name.pascalCase()}}Dto(
       id: domain.id,
     );
   }
 
+  factory {{entity_name.pascalCase()}}Dto.fromJson(Map<String, dynamic> json) =>
+      _${{entity_name.pascalCase()}}DtoFromJson(json);
+
+  const {{entity_name.pascalCase()}}Dto._();
+
   {{entity_name.pascalCase()}} toDomain() {
     return {{entity_name.pascalCase()}}(
       id: id,
     );
   }
-
-  factory {{entity_name.pascalCase()}}Dto.fromJson(Map<String, dynamic> json) =>
-      _${{entity_name.pascalCase()}}DtoFromJson(json);
 }
diff --git a/...transfer_object/__brick__/lib/src/{{{output_dir}}}/{{entity_name.snakeCase()}}_dto.g.dart b/...transfer_object/__brick__/lib/src/{{{output_dir}}}/{{entity_name.snakeCase()}}_dto.g.dart
diff --git a/...sfer_object/__brick__/test/src/{{{output_dir}}}/{{entity_name.snakeCase()}}_dto_test.dart b/...sfer_object/__brick__/test/src/{{{output_dir}}}/{{entity_name.snakeCase()}}_dto_test.dart
@@ -7,7 +7,7 @@ void main() {
     group('.()', () {
       test('returns correct instance', () {
         // Act
-        final {{entity_name.camelCase()}}Dto = {{entity_name.pascalCase()}}Dto(id: 'some_id');
+        const {{entity_name.camelCase()}}Dto = {{entity_name.pascalCase()}}Dto(id: 'some_id');
 
         // Assert
         expect({{entity_name.camelCase()}}Dto.id, 'some_id');
@@ -17,10 +17,10 @@ void main() {
     group('.fromDomain()', () {
       test('returns correct instance', () {
         // Arrange
-        final {{entity_name.camelCase()}} = {{entity_name.pascalCase()}}(id: 'some_id');
+        const {{entity_name.camelCase()}} = {{entity_name.pascalCase()}}(id: 'some_id');
 
         // Act + Assert
-        expect({{entity_name.pascalCase()}}Dto.fromDomain({{entity_name.camelCase()}}), {{entity_name.pascalCase()}}Dto(id: 'some_id'));
+        expect({{entity_name.pascalCase()}}Dto.fromDomain({{entity_name.camelCase()}}), const {{entity_name.pascalCase()}}Dto(id: 'some_id'));
       });
     });
 
@@ -30,7 +30,7 @@ void main() {
         final {{entity_name.camelCase()}}Json = {'id': 'some_id'};
 
         // Act + Assert
-        expect({{entity_name.pascalCase()}}Dto.fromJson({{entity_name.camelCase()}}Json), {{entity_name.pascalCase()}}Dto(id: 'some_id'));
+        expect({{entity_name.pascalCase()}}Dto.fromJson({{entity_name.camelCase()}}Json), const {{entity_name.pascalCase()}}Dto(id: 'some_id'));
       });
 
       test('throws when json is invalid', () {
@@ -42,17 +42,17 @@ void main() {
     group('.toDomain()', () {
       test('returns correct entity', () {
         // Arrange
-        final {{entity_name.camelCase()}}Dto = {{entity_name.pascalCase()}}Dto(id: 'some_id');
+        const {{entity_name.camelCase()}}Dto = {{entity_name.pascalCase()}}Dto(id: 'some_id');
 
         // Act + Assert
-        expect({{entity_name.camelCase()}}Dto.toDomain(), {{entity_name.pascalCase()}}(id: 'some_id'));
+        expect({{entity_name.camelCase()}}Dto.toDomain(), const {{entity_name.pascalCase()}}(id: 'some_id'));
       });
     });
 
     group('.toJson()', () {
       test('returns correct json', () {
         // Arrange
-        final {{entity_name.camelCase()}}Dto = {{entity_name.pascalCase()}}Dto(id: 'some_id');
+        const {{entity_name.camelCase()}}Dto = {{entity_name.pascalCase()}}Dto(id: 'some_id');
 
         // Act + Assert
         expect({{entity_name.camelCase()}}Dto.toJson(), {'id': 'some_id'});

diff --git a/bricks/di_package/__brick__/analysis_options.yaml b/bricks/di_package/__brick__/analysis_options.yaml
@@ -1,30 +1,6 @@
-# This file configures the static analysis results for your project (errors,
-# warnings, and lints).
-#
-# This enables the 'recommended' set of lints from `package:lints`.
-# This set helps identify many issues that may lead to problems when running
-# or consuming Dart code, and enforces writing Dart using a single, idiomatic
-# style and format.
-#
-# If you want a smaller set of lints you can change this to specify
-# 'package:lints/core.yaml'. These are just the most critical lints
-# (the recommended set includes the core lints).
-# The core lints are also what is used by pub.dev for scoring packages.
-
-include: package:lints/recommended.yaml
-
+include: ../../../analysis_options.yaml
 # Uncomment the following section to specify additional rules.
 
 # linter:
 #   rules:
 #     - camel_case_types
-
-# analyzer:
-#   exclude:
-#     - path/to/excluded/files/**
-
-# For more information about the core and recommended set of lints, see
-# https://dart.dev/go/core-lints
-
-# For additional information about configuring this file, see
-# https://dart.dev/guides/language/analysis-options
diff --git a/bricks/di_package/__brick__/lib/{{project_name}}_di.dart b/bricks/di_package/__brick__/lib/{{project_name}}_di.dart
@@ -1,6 +1,7 @@
 /// Dependency Injection for {{project_name.titleCase()}}.
 ///
-/// This contains the container and annotations required for dependency injection.
+/// This contains the container and annotations required for dependency
+/// injection.
 ///
 /// To use, import `package:{{project_name}}_di/{{project_name}}_di.dart`.
 library {{project_name}}_di;

diff --git a/bricks/di_package/__brick__/pubspec.yaml b/bricks/di_package/__brick__/pubspec.yaml
@@ -11,5 +11,4 @@ dependencies:
   injectable: ^2.3.0
 
 dev_dependencies:
-  lints: ^2.1.1
   test: ^1.24.6
diff --git a/bricks/domain_package/__brick__/analysis_options.yaml b/bricks/domain_package/__brick__/analysis_options.yaml
@@ -1,30 +1,6 @@
-# This file configures the static analysis results for your project (errors,
-# warnings, and lints).
-#
-# This enables the 'recommended' set of lints from `package:lints`.
-# This set helps identify many issues that may lead to problems when running
-# or consuming Dart code, and enforces writing Dart using a single, idiomatic
-# style and format.
-#
-# If you want a smaller set of lints you can change this to specify
-# 'package:lints/core.yaml'. These are just the most critical lints
-# (the recommended set includes the core lints).
-# The core lints are also what is used by pub.dev for scoring packages.
-
-include: package:lints/recommended.yaml
-
+include: ../../../../analysis_options.yaml
 # Uncomment the following section to specify additional rules.
 
 # linter:
 #   rules:
 #     - camel_case_types
-
-# analyzer:
-#   exclude:
-#     - path/to/excluded/files/**
-
-# For more information about the core and recommended set of lints, see
-# https://dart.dev/go/core-lints
-
-# For additional information about configuring this file, see
-# https://dart.dev/guides/language/analysis-options
diff --git a/...ain_package/__brick__/lib/{{project_name}}_domain{{#has_name}}_{{name}}{{/has_name}}.dart b/...ain_package/__brick__/lib/{{project_name}}_domain{{#has_name}}_{{name}}{{/has_name}}.dart
@@ -1,4 +1,4 @@
-/// TODO: description here
+// TODO: description here
 ///
 /// To use, import `package:{{project_name}}_domain{{#has_name}}_{{name}}{{/has_name}}/{{project_name}}_domain{{#has_name}}_{{name}}{{/has_name}}.dart`.
 library {{project_name}}_domain{{#has_name}}_{{name}}{{/has_name}};
diff --git a/bricks/domain_package/__brick__/pubspec.yaml b/bricks/domain_package/__brick__/pubspec.yaml
@@ -11,7 +11,6 @@ dependencies:
   freezed_annotation: ^2.4.1
 
 dev_dependencies:
-  lints: ^2.1.1
   test: ^1.24.6
   build_runner: ^2.4.6
   freezed: ^2.4.1

diff --git a/bricks/entity/__brick__/test/src/{{{output_dir}}}/{{name.snakeCase()}}_test.dart b/bricks/entity/__brick__/test/src/{{{output_dir}}}/{{name.snakeCase()}}_test.dart
@@ -6,7 +6,7 @@ void main() {
     group('.()', () {
       test('returns correct instance', () {
         // Arrange + Act
-        final {{name.camelCase()}} = {{name.pascalCase()}}(id: 'some_id');
+        const {{name.camelCase()}} = {{name.pascalCase()}}(id: 'some_id');
 
         // Assert
         expect({{name.camelCase()}}.id, 'some_id');

diff --git a/bricks/infrastructure_package/__brick__/analysis_options.yaml b/bricks/infrastructure_package/__brick__/analysis_options.yaml
@@ -1,32 +1,6 @@
-# This file configures the static analysis results for your project (errors,
-# warnings, and lints).
-#
-# This enables the 'recommended' set of lints from `package:lints`.
-# This set helps identify many issues that may lead to problems when running
-# or consuming Dart code, and enforces writing Dart using a single, idiomatic
-# style and format.
-#
-# If you want a smaller set of lints you can change this to specify
-# 'package:lints/core.yaml'. These are just the most critical lints
-# (the recommended set includes the core lints).
-# The core lints are also what is used by pub.dev for scoring packages.
-
-include: package:lints/recommended.yaml
-
+include: ../../../../analysis_options.yaml
 # Uncomment the following section to specify additional rules.
 
 # linter:
 #   rules:
 #     - camel_case_types
-
-analyzer:
-  exclude:
-    - '**/**.g.dart'
-  errors:
-    invalid_annotation_target: ignore
-
-# For more information about the core and recommended set of lints, see
-# https://dart.dev/go/core-lints
-
-# For additional information about configuring this file, see
-# https://dart.dev/guides/language/analysis-options
diff --git a/bricks/infrastructure_package/__brick__/lib/src/injection.dart b/bricks/infrastructure_package/__brick__/lib/src/injection.dart
@@ -4,4 +4,4 @@ import 'package:injectable/injectable.dart';
 ///
 /// For more info see: https://pub.dev/packages/injectable#including-micropackages-and-external-modules
 @InjectableInit.microPackage()
-initMicroPackage() {}
+void initMicroPackage() {}
diff --git a/bricks/infrastructure_package/__brick__/lib/src/injection.module.dart b/bricks/infrastructure_package/__brick__/lib/src/injection.module.dart
@@ -1,7 +1,6 @@
 //@GeneratedMicroModule;{{project_name.pascalCase()}}Infrastructure{{#has_name}}{{name.pascalCase()}}{{/has_name}}PackageModule;package:{{project_name}}_infrastructure{{#has_name}}_{{name}}{{/has_name}}/src/injection.module.dart
 // GENERATED CODE - DO NOT MODIFY BY HAND
-// ignore_for_file: unnecessary_lambdas
-// ignore_for_file: lines_longer_than_80_chars
+// ignore_for_file: type=lint
 // coverage:ignore-file
 
 // ignore_for_file: no_leading_underscores_for_library_prefixes

diff --git a/...age/__brick__/lib/{{project_name}}_infrastructure{{#has_name}}_{{name}}{{/has_name}}.dart b/...age/__brick__/lib/{{project_name}}_infrastructure{{#has_name}}_{{name}}{{/has_name}}.dart
@@ -1,4 +1,4 @@
-/// TODO: description here
+// TODO: description here
 ///
 /// To use, import `package:{{project_name}}_infrastructure{{#has_name}}_{{name}}{{/has_name}}/{{project_name}}_infrastructure{{#has_name}}_{{name}}{{/has_name}}.dart`.
 library {{project_name}}_infrastructure{{#has_name}}_{{name}}{{/has_name}};

diff --git a/bricks/infrastructure_package/__brick__/pubspec.yaml b/bricks/infrastructure_package/__brick__/pubspec.yaml
@@ -14,7 +14,6 @@ dependencies:
   {{project_name}}_domain{{#has_name}}_{{name}}{{/has_name}}:
 
 dev_dependencies:
-  lints: ^2.1.1
   test: ^1.24.6
   mocktail: ^1.0.0
   build_runner: ^2.4.6

diff --git a/bricks/logging_package/__brick__/analysis_options.yaml b/bricks/logging_package/__brick__/analysis_options.yaml
@@ -1,30 +1,6 @@
-# This file configures the static analysis results for your project (errors,
-# warnings, and lints).
-#
-# This enables the 'recommended' set of lints from `package:lints`.
-# This set helps identify many issues that may lead to problems when running
-# or consuming Dart code, and enforces writing Dart using a single, idiomatic
-# style and format.
-#
-# If you want a smaller set of lints you can change this to specify
-# 'package:lints/core.yaml'. These are just the most critical lints
-# (the recommended set includes the core lints).
-# The core lints are also what is used by pub.dev for scoring packages.
-
-include: package:lints/recommended.yaml
-
+include: ../../../analysis_options.yaml
 # Uncomment the following section to specify additional rules.
 
 # linter:
 #   rules:
 #     - camel_case_types
-
-# analyzer:
-#   exclude:
-#     - path/to/excluded/files/**
-
-# For more information about the core and recommended set of lints, see
-# https://dart.dev/go/core-lints
-
-# For additional information about configuring this file, see
-# https://dart.dev/guides/language/analysis-options
diff --git a/bricks/logging_package/__brick__/lib/src/injection.dart b/bricks/logging_package/__brick__/lib/src/injection.dart
@@ -4,4 +4,4 @@ import 'package:injectable/injectable.dart';
 ///
 /// For more info see: https://pub.dev/packages/injectable#including-micropackages-and-external-modules
 @InjectableInit.microPackage()
-initMicroPackage() {}
+void initMicroPackage() {}
diff --git a/bricks/logging_package/__brick__/lib/src/injection.module.dart b/bricks/logging_package/__brick__/lib/src/injection.module.dart
@@ -1,7 +1,6 @@
 //@GeneratedMicroModule;{{project_name.pascalCase()}}LoggingPackageModule;package:{{project_name}}_logging/src/injection.module.dart
 // GENERATED CODE - DO NOT MODIFY BY HAND
-// ignore_for_file: unnecessary_lambdas
-// ignore_for_file: lines_longer_than_80_chars
+// ignore_for_file: type=lint
 // coverage:ignore-file
 
 // ignore_for_file: no_leading_underscores_for_library_prefixes

diff --git a/bricks/logging_package/__brick__/lib/src/logger.dart b/bricks/logging_package/__brick__/lib/src/logger.dart
@@ -13,9 +13,10 @@ enum Level {
   wtf(1200),
   nothing(2000);
 
-  final int value;
   const Level(this.value);
 
+  final int value;
+
   bool operator >=(Level level) => value >= level.value;
 }
 
@@ -29,13 +30,13 @@ typedef LogCommand = void Function(
 
 /// The logger of the application.
 abstract class {{project_name.pascalCase()}}Logger {
+  {{project_name.pascalCase()}}Logger(this.level);
+
   final Level level;
 
   @visibleForTesting
   LogCommand? logCommandOverrides;
 
-  {{project_name.pascalCase()}}Logger(this.level);
-
   LogCommand get _logCommand => logCommandOverrides ?? log;
 
   /// Log a message at level [Level.verbose].

diff --git a/bricks/logging_package/__brick__/pubspec.yaml b/bricks/logging_package/__brick__/pubspec.yaml
@@ -11,7 +11,6 @@ dependencies:
   injectable: ^2.3.0
 
 dev_dependencies:
-  lints: ^2.1.1
   test: ^1.24.6
   mocktail: ^1.0.0
   build_runner: ^2.4.6

diff --git a/bricks/logging_package/__brick__/test/mocks.dart b/bricks/logging_package/__brick__/test/mocks.dart
@@ -1,5 +1,6 @@
 import 'package:mocktail/mocktail.dart';
 
+// ignore: one_member_abstracts
 abstract class _LogCommand {
   void call(
     String message, {