Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: @sveltejs/kit/install-fetch replaced in @sveltejs/kit 1.0.0-next.341 #169

Closed
pham opened this issue May 24, 2022 · 0 comments · Fixed by #170
Closed

bug: @sveltejs/kit/install-fetch replaced in @sveltejs/kit 1.0.0-next.341 #169

pham opened this issue May 24, 2022 · 0 comments · Fixed by #170
Labels
bug Something isn't working

Comments

@pham
Copy link
Contributor

pham commented May 24, 2022

Describe the Bug

@sveltejs/kit/install-fetch has been replaced with @sveltejs/kit/node/polyfills in 1.0.0-next.341 (#4934).

Building against the latest @sveltejs/kit produces the error:

> Using svelte-adapter-firebase
✘ [ERROR] Could not resolve "@sveltejs/kit/install-fetch"

    node_modules/svelte-adapter-firebase/src/files/shims.js:1:27:
      1 │ import {installFetch} from '@sveltejs/kit/install-fetch';
        ╵                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  The path "./install-fetch" is not exported by package "@sveltejs/kit":

    node_modules/@sveltejs/kit/package.json:47:13:
      47 │   "exports": {
         ╵              ^

Steps to Reproduce

$ svelte-kit build

Expected Behaviour

> Using svelte-adapter-firebase
  ✔ done

svelte-adapter-firebase version

0.14.0

sveltejs/kit version

1.0.0-next.341

@pham pham added the bug Something isn't working label May 24, 2022
pham added a commit to pham/svelte-adapter-firebase that referenced this issue May 24, 2022
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Jun 2, 2022
Nushio added a commit that referenced this issue Jun 8, 2022
* fix(#169): Replace @sveltejs/kit/install-fetch with @sveltejs/kit/node/polyfills

* chore(#169): Update pnpm-lock.yaml to pass the unit test

* chore: release 0.14.1

* fix: integration tests

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Juan Rodriguez <jrodriguez@isotalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant