Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: SvelteKit v1.0.0-next-382 removed writeStatic causes build to break #172

Closed
pham opened this issue Jul 20, 2022 · 1 comment · Fixed by #173
Closed

bug: SvelteKit v1.0.0-next-382 removed writeStatic causes build to break #172

pham opened this issue Jul 20, 2022 · 1 comment · Fixed by #173
Labels
bug Something isn't working

Comments

@pham
Copy link
Contributor

pham commented Jul 20, 2022

Describe the Bug

SvelteKit removed writeStatic to align with Vite #5618.

Build output:

> Using svelte-adapter-firebase
error during build:
Error: writeStatic has been removed. Please ensure you are using the latest version of svelte-adapter-firebase

Steps to Reproduce

npx vite build

Expected Behaviour

Output should look like:

> Using svelte-adapter-firebase
  ✔ done

svelte-adapter-firebase version

0.14.1

sveltejs/kit version

1.0.0-next-382
@pham pham added the bug Something isn't working label Jul 20, 2022
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Jul 20, 2022
@pham
fix(jthegedus#172): Remove reference to obsoleted writeStatic
d5760ca
@github-actions github-actions bot mentioned this issue Jul 20, 2022
Merged
@pham pham mentioned this issue Jul 20, 2022
Merged
jthegedus added a commit that referenced this issue Aug 7, 2022
@pham @github-actions @jthegedus
fix(#172): Remove reference to obsoleted writeStatic (#173)
9a990a0 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: James Hegedus <jthegedus@hey.com>
@github-actions github-actions bot mentioned this issue Aug 7, 2022
Merged
@x-o1d
Copy link

x-o1d commented Aug 11, 2022

same issue with sveltekit 405, but commenting out 9a990a0 works.
any idea when 0.14.2 will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#172): Remove reference to obsoleted writeStatic pham/svelte-adapter-firebase
2 participants
@pham @x-o1d