Write prerendered files to public dir #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pham
added a commit
to pham/svelte-adapter-firebase
that referenced
this pull request
Jan 15, 2023
pham
added a commit
to pham/svelte-adapter-firebase
that referenced
this pull request
Jan 16, 2023
jthegedus
pushed a commit
that referenced
this pull request
Jan 17, 2023
jthegedus
added a commit
that referenced
this pull request
Jan 17, 2023
jthegedus
added a commit
that referenced
this pull request
Jan 17, 2023
* chore: bump asdf tools * chore: bump dependencies * chore: apply xojs fixes * test: bump test functions to nodejs18 * test: bump test deps & devdeps * fix: rm check of runtime version assume nodejs18 * docs: update compat table * test: fix end-to-end test firebase config * chore(deps): Bump kit v1.1.1; ava, xo, esbuild, firebase-functions * fix(lint): Use explicit `import type` statement * fix(lint): Use the preferred nullish coalescing op over ternary * test(version): Switch to `checkout@v3` to get rid of Node.js 12 warnings * feat: Add Node.js 18 support * fix: Missing 2nd argument for (reading 'prerendering' error) * fix(#200/@AndrewLester): Write prerendered fiels to public directory * test(version): Add Node.js 18 to test cases * fix(test): Add static route for `/about`. Switch from Svelte demo -> sverdle * fix(test): Missing quote in `firebase.json`. Change label in test from Todos to Sverdle Co-authored-by: Paul Pham <paul@aquaron.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Write prerendered files to the public dir. This PR also changes the temp dir to be
.svelte-kit/svelte-adapter-firebaserather than.svelte-kit/.svelte-kit.Relevant: #190
Other Information
I'm not sure if this even works because I haven't been able to test it myself. It also might need to turn on cleanUrls? This PR also doesn't handle prerendered redirects.
At best maybe someone can work off of this PR? Otherwise it can be closed if it's not useful.
EDIT: I turned on "cleanUrls" and now the /about and / routes are working. /todos doesn't work because somewhere
prerenderingisn't defined, and I'm not sure where that comes from.