Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: sync with kit@1.1.1 based on (PRs #194 #200) #203

Merged
merged 20 commits into from
Jan 17, 2023
Merged

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Jan 17, 2023

This is a re-raise of #201 by @pham 🙇

Summary

  • Fix missing 2nd arg for Server.respond() causing TypeError (see error dump below)
  • Add prerendered files to public dir (thanks @AndrewLester)
  • Add Node.js 18 support

Fixes: #194 #200 #201 #202

TypeError

⚠  functions: TypeError: Cannot read properties of undefined (reading 'prerendering')
    at respond (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31409:14)
    at Server.respond (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31705:12)
    at svelteKit (/tmp/svelte-adapter-firebase-wxGf/functions/sveltekit/index.js:31767:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async runFunction (/tmp/svelte-adapter-firebase-wxGf/node_modules/firebase-

I misunderstood how release-please computes conventional-commit breaking changes (!) with the type chore, so my merge of #201 was erroneous. I have recreated the PR here. @pham sorry. The reason for the change of conventional-commit type was because this change is breaking, so the initial fix: would only create a semver patch update, not a semver minor update, fix!: would create a semver minor update.

@jthegedus jthegedus changed the title chore: bump asdf tools fix!: sync with kit@1.1.1 based on (PRs #194 #200) Jan 17, 2023
@jthegedus jthegedus merged commit 352072d into jthegedus:main Jan 17, 2023
@github-actions github-actions bot mentioned this pull request Jan 17, 2023
@pham
Copy link
Contributor

pham commented Jan 18, 2023

Thanks for the merge @jthegedus! Appreciate the work you're doing!

@evdama
Copy link

evdama commented Jan 18, 2023

I second that... very very much thanks to you @jthegedus 👏 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants