Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte Fetch is not included on the Firebase build #37

Closed
nielsvandermolen opened this issue Apr 30, 2021 · 2 comments · Fixed by #39
Closed

Svelte Fetch is not included on the Firebase build #37

nielsvandermolen opened this issue Apr 30, 2021 · 2 comments · Fixed by #39
Labels

Comments

@nielsvandermolen
Copy link
Contributor

Describe the bug
The todo page does not work when deploying the demo example project on Firebase with this adapter. It will throw: ReferenceError: fetch is not defined

To Reproduce
deploy the demo application on Firebase and go to the todos page

Expected behavior

That the fetch calls to the external API would work and no errors are thrown.

Screenshots

Additional context

There is some recent work in the official adapters to support Fetch
sveltejs/kit#1066
sveltejs/kit#1091

I am not sure if the solution is to ``import '@sveltejs/kit/install-fetch' or that we have to do something with node-fetch
sveltejs/kit#618 (comment)

@jthegedus
Copy link
Owner

Current SvelteKit version support is @svelte/kit@1.0.0-next.54, I am updating to @svelte/kit@1.0.0-next.94 atm and will include this fix.

I will also put a adapter version <--> sveltekit version table in the repo so people are aware.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants