Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter bundle #1091

Merged
merged 13 commits into from
Apr 18, 2021
Merged

Adapter bundle #1091

merged 13 commits into from
Apr 18, 2021

Conversation

Rich-Harris
Copy link
Member

Mostly just playing around for now, but this is intended to solve the perennial problem of dependencies behaving weirdly, by allowing adapters to determine what gets bundled.

For example, adapter-node doesn't need to bundle anything, but an adapter for a serverless platform might. Right now I'm trying to get esbuild to bundle everything inside the Vercel adapter, but it's possible that this belongs in an adapter util.

admin

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@vercel
Copy link

vercel bot commented Apr 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit-demo/3AHB186gqcGRxrwTR1o6hkgCSGud
✅ Preview: https://kit-demo-git-adapter-bundle-sveltejs1.vercel.app

@Rich-Harris Rich-Harris marked this pull request as ready for review April 18, 2021 14:33
@Rich-Harris
Copy link
Member Author

This is a little tricky to test without actually releasing new adapter versions and trying to deploy stuff with them, so I'm going to do exactly that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants