Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use SK computed config to determine if static dirs differ #97

Merged
merged 5 commits into from
May 30, 2021

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented May 30, 2021

Summary

  • use SvelteKit computed config to determine if svelte.config.js:config.kit.files.assets === firebase.json:hosting[].public. This fixes the current brittle soln which dynamically imports the raw config file which is before SvelteKit computes all properties.
  • fix xojs issues
  • document no compatible version of adapter for @sveltejs/kit@next.109

Fixes: #56

Other Information

@jthegedus jthegedus changed the title docs: update version compat table docs: use SvelteKit computed config to determine if static dirs differ May 30, 2021
@jthegedus jthegedus changed the title docs: use SvelteKit computed config to determine if static dirs differ fix: use SvelteKit computed config to determine if static dirs differ May 30, 2021
@jthegedus jthegedus changed the title fix: use SvelteKit computed config to determine if static dirs differ fix: use SK computed config to determine if static dirs differ May 30, 2021
@jthegedus jthegedus merged commit 53e3c97 into main May 30, 2021
@jthegedus jthegedus deleted the fix/ensure-static-dirs-differ branch May 30, 2021 09:23
github-actions bot pushed a commit that referenced this pull request May 30, 2021
## [0.8.3](v0.8.2...v0.8.3) (2021-05-30)

### Bug Fixes

* use SK computed config to determine if static dirs differ ([#97](#97)) ([53e3c97](53e3c97))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ensure static resource destination differs from each of the sources
1 participant