Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A collection of changes #1285

Merged
merged 8 commits into from
Oct 14, 2024
Merged

A collection of changes #1285

merged 8 commits into from
Oct 14, 2024

Conversation

loops
Copy link
Contributor

@loops loops commented Oct 13, 2024

Hi, I was unsure whether to submit just one PR, or one-for-each small change. If you prefer them broken up into multiple PRs, just say so.

  • Add option to ignore hardware repeat events
  • Add abiity to execute a given alias at startup
  • Add a README on how to convert .adoc to .html
  • Add a cfg_sample for learning the Colemak layout
  • Add --quiet command line option

Full disclosure: Even though Mac and MSwin are mentioned in passing, I've only compiled and tested these on Linux.

Checklist

  • Add documentation to docs/config.adoc
    • [ ✔️] Yes or N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • [✔️ ] Yes or N/A
  • Update error messages
    • [ ✔️] Yes or N/A
  • Added tests, or did manual testing
    • [ ✔️] Yes

Copy link
Owner

@jtroo jtroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple PRs would be preferable 🙂

docs/config.adoc Show resolved Hide resolved
parser/src/cfg/mod.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
docs/config.adoc Outdated Show resolved Hide resolved
loops added 8 commits October 13, 2024 07:29
Document new "allow-hardware-repeat" config option which
is "true" by default.  Set to "no", to disable hardware
repeat-key events.
Drop any repeat-key events emitted by the keyboard or kernel.
Only implemented for Linux and Mac.
Document the new "alias-to-trigger-on-load" configuration option.
Store the name of the selected alias internally.  Defer using it,
until aliases are actually parsed as well.  The alias name given
as a parameter, does not expect a leading "@".
Now that the aliases have all been parsed, lookup the action
associated with the correct one, and enqueue it to run.
Useful to avoid filling up log files when being run as a service.
@jtroo jtroo merged commit 310aaa0 into jtroo:main Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants