Macos support #652
Merged
Macos support #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed, probably it needs to be handled in a cleaner way from driverkit instead
This allows a user to define devices using a sexpr list. The old way (colon separated string) is not removed for compatibility.
rszyma
reviewed
Dec 8, 2023
rszyma
reviewed
Dec 8, 2023
|
Just wanted to stop by to say how excited I am to see this! Thank you very much for working on it. |
jtroo
reviewed
Dec 8, 2023
src/oskbd/macos.rs
Outdated
| /// Send using C-S-u + <unicode hex number> + spc | ||
| pub fn send_unicode(&mut self, c: char) -> Result<(), io::Error> { | ||
| log::debug!("sending unicode {c}"); | ||
| todo!(); |
There was a problem hiding this comment.
It's also fine to not implement this yet - maybe macos doesn't even have any unicode output solution?
If left unimplemented, I wonder if it's better to have a log::error! call rather than panic with a todo... I don't feel too strongly either way for now.
|
I attempted to build it on the latest macOS version on a M1 and got this error: Not sure if relevant to the PR or just something on my machine. I am using the sold linker. UPDATE: Builds fine if I don't use the sold linker. |
rszyma
reviewed
Dec 8, 2023
added 2 commits
December 9, 2023 00:34
rszyma
reviewed
Dec 8, 2023
rszyma
suggested changes
Dec 9, 2023
rszyma
reviewed
Dec 9, 2023
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Checklist