Add ’tap-hold-except-keys’ functionality #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtroo
reviewed
Dec 8, 2023
docs/config.adoc
Outdated
| This variant takes a 5th parameter which is a list of keys | ||
| that always trigger a tap | ||
| when they are pressed while the `tap-hold-except-keys` action is waiting. | ||
| Otherwise this behaves as `tap-hold`. |
There was a problem hiding this comment.
Otherwise this behaves as
tap-hold.
Not having tested the changes, and based on my understanding from reading comments and code, this looks inaccurate.
tap-hold-except-keys does not ever output a key if no other action has happened right? E.g. another key press, or releasing the key itself.
There was a problem hiding this comment.
Indeed I noticed that when I wanted to Ctrl+scroll…
jtroo
force-pushed
the
main
branch
7 times, most recently
from
d10943b to
6fbffdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
tap-hold-except-keysbehaves like atap-holdkey except for a list of physical keys which will always trigger a tap.This helps avoid typing fast errors with homerow mods for example.
More details here: #128 (comment)
Checklist