C++20 compilation failed because of PQXX_UNLIKELY

[TmLev]

Error message from clang++-12:

error: no return statement in constexpr function
constexpr tx_stat parse_status(std::string_view text) noexcept

Removing this line just before the return statement seems to fix the issue.

[jtv]

Thanks for reporting. What compiler is this, and what error does it give you?

…

On Tue, Aug 17, 2021, 12:56 Lev Khoroshansky ***@***.***> wrote: Error message: constexpr tx_stat parse_status(std::string_view text) noexcept``` Removing [this line just before return](https://github.com/jtv/libpqxx/blob/8d17b559753cbd9f0c79d7f6ec68ac9b33259beb/src/robusttransaction.cxx#L67) seems to fix the issue. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#475>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAQYDE36GK3PUW5C3MBIRKLT5I54HANCNFSM5CJTFR5A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

[TmLev]

@jtv compiler and its error are mentioned in OP of the GitHub issue: #475 (comment)
As well as the pull request that can fix it: #476

[jtv]

Ah, OK, sorry. Read the report on a telephone while dealing with other stuff, so I missed some things. When I try it here (also with clang 12) I get a whole bunch of these warnings. I'll remove those attributes.

[jtv]

@TmLev wow, this is surprising: I just saw the Github email again, and it completely left out the part about the compiler! And it showed only part of the error message, so I didn't recognise it as such.

What I got was:

Error message:

constexpr tx_stat parse_status(std::string_view text) noexcept```

Removing [this line just before return]
(https://github.com/<etc>) seems to fix the issue.

Lesson learned: cant trust the emails...

[TmLev]

@jtv To be fair, I edited OP a bit after opening the issue, so no wonder email didn't catch all of it.