Get Windows tests working & passing. #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should mean I no longer have to configure appveyor in the web UI.
Suppresses an annoying and repetitive warning about Microsoft's `<ranges>` header not working properly in their C++20 implementation.
I finally got the tests running in Windows on appveyor. Which revealed a hanging test in Windows, for the nonblocking connection class. The `pqxx::connecting` class tried to manage blocking/nonblocking states on the connection. But there does not seem to be any need: libpq does all of that for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an
appveyor.yml. This should mean I no longer have to configure appveyor in the web UI. And more of the test is set up automatically, without awkward scripting in various convoluted languages.But it also gave me the opportunity to get the tests running on Windows. And guess what? They didn't all pass! The test for asynchronous connection (using
pqxx::connecting) would hang. Turns out it was completely unnecessary for libpqxx to manage blocking/nonblocking mode on the socket. So that's fixed now.