Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded cmp0074 new #876

Merged
merged 9 commits into from
Aug 3, 2024

Conversation

killerbot242
Copy link
Contributor

No description provided.

The following comments explains why it was added, and that indeed it is no longer needed, as such.
jtv#851 (comment)

Note that neither of these 2 cmake modules are for public use, they are internal cmake stuff.
Nothing on the outside should use it. This was feedback given by kitware developers.
Revert "remove a use added for a purpose which is gone in the meantime."

This reverts commit 7fdd2f8.
@jtv
Copy link
Owner

jtv commented Aug 3, 2024

Thanks once again!

@jtv jtv merged commit 4ad6087 into jtv:master Aug 3, 2024
6 checks passed
@killerbot242
Copy link
Contributor Author

a question : how should 'generate_check_config.py" be called, from which location, what command line options ... ?

@jtv
Copy link
Owner

jtv commented Aug 3, 2024

@killerbot242 the autogen.sh script calls it. If you want to regenerate the CMake setup (some files are generated from templates) and the confgure script, you run autogen.sh.

If you don't want to do the whole thing but do want to run parts, look at autogen.sh for examples. Or run tools/generate_check_config.py --help.

@killerbot242
Copy link
Contributor Author

when I run the script as in the autogen.sh (no command line options) or even with --help, I always get this error.

./tools/generate_check_config.py --help
Traceback (most recent call last):
File "./tools/generate_check_config.py", line 38, in
def list_snippets(source: Path) -> list[str]:
TypeError: 'type' object is not subscriptable

@jtv
Copy link
Owner

jtv commented Aug 6, 2024

You just be running an older python version. Try a newer one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants