ACL refactor #1381
Merged
ACL refactor #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
force-pushed
the
acl-refactor
branch
2 times, most recently
from
9c90ea8
to
0c9aec4
Compare
kradalby
commented
Apr 27, 2023
kradalby
commented
Apr 27, 2023
|
@kradalby Is there any chance of an image pushed to a public registry for trying out the changes directly? |
|
@ventsislav-georgiev sorry, its being continuously updated, so its not really feasible with our current release pipeline, we dont support or build docker officially. There is a binary attached to the build job on this PR. |
kradalby
force-pushed
the
acl-refactor
branch
4 times, most recently
from
028ee4b
to
9fd67dc
Compare
|
Hi, about the potential ACL API, what is the current plan ? |
|
@loprima-l no plan, I have no intention of implementing an API for ACLs. The current state is that some people want it, and have discussed how to do it, and we will accept an implementation that fits into the project. But it is currently not part of our priorities, and I do not think this will change for a long time. |
kradalby
force-pushed
the
acl-refactor
branch
5 times, most recently
from
28843f7
to
917956b
Compare
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
juanfont
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General QoL improvements to the ACL code, naming, splitting up larger functions, some more tests at different layers.
Rewrite of the filtering of peers served as part of MapResponses, fixing #1372, undoing #1239, #1377, redoing #320.
Small contribution to laying the groundwork for improving SSH support.