Fix integration test issues due to multi-arch #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
previously approved these changes
Jul 31, 2022
|
Going to close this, as we need to investigate what is making the continuous integration tests fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our integration tests are broken due to the changes in the Dockerfile to add multi-arch support.
This is due to the lack of support in the dockertest library for the new BuildKit library from docker/moby. I have set a PR to dockertest to fix that ory/dockertest#374
This PR changes the integration tests to use the patched version of dockertest, and replaces the library in go.mod to point to my fork. Hopefully this last part will be removed in a few days.