Merge pull request datacarpentry#268 from maxim-belkin/fix-returns

util.py: make functions return NotImplemented
juanfrh · May 23, 2018 · 961f24a · 961f24a
2 parents 894d47f + dd1fce0
commit 961f24a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/bin/util.py b/bin/util.py
@@ -74,8 +74,9 @@ def pretty(item):
             return location + ': ' + message
         elif isinstance(location, tuple):
             return '{0}:{1}: '.format(*location) + message
-        else:
-            assert False, 'Unknown item "{0}"'.format(item)
+
+        print('Unknown item "{0}"'.format(item), file=sys.stderr)
+        return NotImplemented
 
     @staticmethod
     def key(item):
@@ -86,8 +87,9 @@ def key(item):
             return (location, -1, message)
         elif isinstance(location, tuple):
             return (location[0], location[1], message)
-        else:
-            assert False, 'Unknown item "{0}"'.format(item)
+
+        print('Unknown item "{0}"'.format(item), file=sys.stderr)
+        return NotImplemented
 
     def report(self, stream=sys.stdout):
         """Report all messages in order."""