Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python support from 3.8-3.10 to 3.10-3.12 #269

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

JakobHavtorn
Copy link

@JakobHavtorn JakobHavtorn commented Feb 3, 2025

Description

This PR upgrades the Python version support of diart by allowing matplotlib to upgrade beyond v3.6 (currently v3.10). The changes are the following:

  • Change matplotlib version limits from matplotlib>=3.3.3,<3.6.0 to matplotlib>=3.3.3,<4.0.0.
  • Run tests action pytest.yml with matrix over Python versions 3.10, 3.11, and 3.12 to ensure support.

Testing

  • I have tested this branch on my own use-case with Python 3.11 and it has solved the issue I saw with building matplotlib wheels for diart version v0.9.1. See this reported issue: Update matplotlib Requirement #267.

@JakobHavtorn JakobHavtorn changed the title Support python 3.10, 3.11, and 3.12 Ugrade Python support from 3.8-3.10 to 3.10-3.12 Feb 3, 2025
@juanmc2005 juanmc2005 self-requested a review February 10, 2025 11:15
@juanmc2005 juanmc2005 added the ops Improvements to the project that don't impact the code label Feb 10, 2025
@juanmc2005
Copy link
Owner

Hi @JakobHavtorn! Thank you for submitting this PR!
I just want to make sure all CI checks pass before merging.

Co-authored-by: Juan Coria <juanmc2005@hotmail.com>
@juanmc2005
Copy link
Owner

@JakobHavtorn can you try removing the line sudo add-apt-repository ppa:savoury1/ffmpeg4 from files:

  • .github/workflows/pytest.yml
  • .github/workflows/quick-runs.yml

For some reason the ffmpeg ppa doesn't seem to work anymore and it's blocking the CI.
I think it should work with the latest ffmpeg version anyway. Seems like a good opportunity to fix this issue :)

@juanmc2005 juanmc2005 changed the title Ugrade Python support from 3.8-3.10 to 3.10-3.12 Upgrade Python support from 3.8-3.10 to 3.10-3.12 Feb 11, 2025
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/quick-runs.yml Outdated Show resolved Hide resolved
@juanmc2005 juanmc2005 merged commit 51a76f8 into juanmc2005:develop Feb 11, 2025
7 checks passed
@JakobHavtorn
Copy link
Author

@juanmc2005 Do you think there's a chance we can create a release that includes this? That would make my life a lot easier (read: less risky) 😬

@JakobHavtorn JakobHavtorn deleted the support-recent-pythons branch February 11, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ops Improvements to the project that don't impact the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants