Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed generate_seed() #28

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Fixed generate_seed() #28

merged 1 commit into from
Jul 30, 2019

Conversation

lhiguer1
Copy link
Contributor

The upper left and lower right 3x3 grids are the same. They are both generated using upperleft and lowerright is never used.

@jubalh
Copy link
Owner

jubalh commented Jul 29, 2019 •
edited
Loading

Uhh!! Right!
Funny that noone ever realized this!

Could you do me a favour and rename the commit to present tense: Fix generate_seed()?

git commit --amend
git push -f

@lhiguer1
Fix generate_seed()
9eecb15 
The upper left and lower right 3x3 grids are the same. They are both generated using upperleft and lowerright is never used.
@lhiguer1
Copy link
Contributor Author

How is that?

@jubalh jubalh merged commit 97159ce into jubalh:master Jul 30, 2019
@jubalh
Copy link
Owner

jubalh commented Jul 30, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhiguer1 @jubalh