Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix variable scope issue in undo functionality #59

Merged
merged 1 commit into from
Apr 28, 2024
Merged

build: fix variable scope issue in undo functionality #59

merged 1 commit into from
Apr 28, 2024

Conversation

chenrui333
Copy link
Contributor

see the following build failure in Homebrew/homebrew-core#170273

  main.c:711:5: error: expected expression
                                  move_t old_move;
                                  ^
  main.c:712:25: error: use of undeclared identifier 'old_move'
                                  if (undo_stack_pop(&old_move))
                                                      ^
  main.c:716:9: error: use of undeclared identifier 'old_move'
                                  x = old_move.x;
                                      ^
  main.c:717:9: error: use of undeclared identifier 'old_move'
                                  y = old_move.y;
                                      ^
  main.c:720:31: error: use of undeclared identifier 'old_move'
                                  user_board[posy*9+posx] = old_move.prev_val;
                                                            ^
  5 errors generated.

Signed-off-by: Rui Chen <rui@chenrui.dev>
@jubalh jubalh merged commit 0a16a49 into jubalh:master Apr 28, 2024
@jubalh
Copy link
Owner

jubalh commented Apr 28, 2024

Thanks! Which compiler was used when getting this?

@chenrui333
Copy link
Contributor Author

Thanks! Which compiler was used when getting this?

I am also adding a macos workflow to see if this is reproducible on CI.

@chenrui333
Copy link
Contributor Author

I am using clang

CPU: quad-core 64-bit dunno
Clang: 15.0.0 build 1500
Git: 2.39.3 => /usr/bin/git
Curl: 8.4.0 => /usr/bin/curl
macOS: 14.4.1-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: 15.3
Rosetta 2: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants