Do fallback but issue a warning

judahrand · Nov 10, 2022 · 623ac5d · 623ac5d
1 parent 14a3d93
commit 623ac5d
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/pip/_internal/network/auth.py b/src/pip/_internal/network/auth.py
@@ -154,13 +154,12 @@ def get_keyring_provider() -> KeyRingBaseProvider:
             pass
         except Exception as exc:
             # In the event of an unexpected exception
-            # we shouldn't fallback silently to the
-            # CliProvider
+            # we should warn the user
             logger.warning(
-                "Keyring is skipped due to an exception: %s",
+                "Installed copy of keyring fails with exception %s, "
+                "trying to find a keyring executable as a fallback",
                 str(exc),
             )
-            return KeyRingNullProvider()
 
         # Fallback to Cli Provider if `keyring` isn't installed
         cli = shutil.which("keyring")