Fix header value check

juffalow · Nov 10, 2021 · e0fb391 · e0fb391
1 parent cee164d
commit e0fb391
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/src/html/CSS.ts b/src/html/CSS.ts
@@ -81,11 +81,11 @@ class CSS extends Test {
   }
 
   protected isCached(result: any): boolean {
-    return Object.prototype.hasOwnProperty.call(result.response.headers, 'cache-control');
+    return result.response.headers.has('cache-control');
   }
 
   protected hasXContentTypeOptionsHeader(result: any): boolean {
-    return Object.prototype.hasOwnProperty.call(result.response.headers, 'x-content-type-options');
+    return result.response.headers.has('x-content-type-options');
   }
 
   protected isMinified(result: any): boolean {

diff --git a/src/html/Image.ts b/src/html/Image.ts
@@ -73,11 +73,11 @@ class Image extends Test {
   }
 
   protected isCached(result: any): boolean {
-    return Object.prototype.hasOwnProperty.call(result.response.headers, 'cache-control');
+    return result.response.headers.has('cache-control');
   }
 
   protected hasXContentTypeOptionsHeader(result: any): boolean {
-    return Object.prototype.hasOwnProperty.call(result.response.headers, 'x-content-type-options');
+    return result.response.headers.has('x-content-type-options');
   }
 }
 

diff --git a/src/html/JavaScript.ts b/src/html/JavaScript.ts
@@ -31,6 +31,11 @@ class JavaScript extends Test {
 
       const result = await request.get(script);
 
+      console.log(result.response.headers);
+      console.log(Object.prototype.hasOwnProperty.call(result.response.headers, 'cache-control'));
+      console.log('cache-control' in result.response.headers)
+      console.log(result.response.headers.has('cache-control'))
+
       const isFileAvailabe = {
         status: this.isFileAvailable(result) ? 'SUCCESS' : 'ERROR',
         title: 'Available',
@@ -88,11 +93,11 @@ class JavaScript extends Test {
   }
 
   protected isCached(result: any): boolean {
-    return Object.prototype.hasOwnProperty.call(result.response.headers, 'cache-control');
+    return result.response.headers.has('cache-control');
   }
 
   protected hasXContentTypeOptionsHeader(result: any): boolean {
-    return Object.prototype.hasOwnProperty.call(result.response.headers, 'x-content-type-options');
+    return result.response.headers.has('x-content-type-options');
   }
 
   protected isMinified(result: any): boolean {