SeanRoy#117 Fixed: ResourceConflictException while deploying lambda

juger89 · Sep 17, 2021 · 859ac34 · 859ac34
1 parent 48b9d5b
commit 859ac34
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -48,7 +48,7 @@
     </contributors>
 
     <properties>
-        <aws.version>1.11.271</aws.version>
+        <aws.version>1.12.68</aws.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>
 
@@ -262,7 +262,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-plugin-plugin</artifactId>
-                <version>3.4</version>
+                <version>3.6.1</version>
                 <executions>
                     <execution>
                         <id>default-descriptor</id>

diff --git a/src/main/java/com/github/seanroy/plugins/AbstractLambdaMojo.java b/src/main/java/com/github/seanroy/plugins/AbstractLambdaMojo.java
@@ -17,6 +17,8 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import com.amazonaws.services.lambda.model.GetFunctionRequest;
+import com.amazonaws.services.lambda.model.GetFunctionResult;
 import com.amazonaws.services.lambda.model.UpdateFunctionCodeRequest;
 import com.amazonaws.services.lambda.model.UpdateFunctionCodeResult;
 import com.amazonaws.services.s3.model.*;
@@ -293,6 +295,24 @@ void uploadJarToS3() throws Exception {
                 .withS3Key(fileName)
                 .withPublish(lambdaFunction.isPublish());
         UpdateFunctionCodeResult updateFunctionCodeResult = lambdaClient.updateFunctionCode(updateFunctionRequest);
+
+        // wait until the UpdateFunctionCode finishes processing to avoid com.amazonaws.services.lambda.model.ResourceConflictException. See: https://docs.aws.amazon.com/lambda/latest/dg/functions-states.html
+        GetFunctionRequest getFunctionRequest = new GetFunctionRequest()
+                .withFunctionName(lambdaFunction.getFunctionName());
+        GetFunctionResult getFunctionResult = lambdaClient.getFunction(getFunctionRequest);
+
+        while (!getFunctionResult.getConfiguration().getState().equals("Active")
+                || !getFunctionResult.getConfiguration().getLastUpdateStatus().equals("Successful")) {
+            try {
+                getLog().info(String.format("UpdateFunctionCode for %s is still processing <State: %s, LastUpdateStatus: %s>, waiting... ", lambdaFunction.getFunctionName(), getFunctionResult.getConfiguration().getState(), getFunctionResult.getConfiguration().getLastUpdateStatus()));
+                Thread.sleep(3000);
+                getFunctionResult = lambdaClient.getFunction(getFunctionRequest);
+            } catch (InterruptedException e) {
+                e.printStackTrace();
+            }
+        }
+        getLog().info("UpdateFunctionCode finished successfully for " + lambdaFunction.getFunctionName());
+
         return lambdaFunction
                 .withVersion(updateFunctionCodeResult.getVersion())
                 .withFunctionArn(updateFunctionCodeResult.getFunctionArn());

diff --git a/src/main/java/com/github/seanroy/utils/JsonUtil.java b/src/main/java/com/github/seanroy/utils/JsonUtil.java
@@ -45,6 +45,6 @@ public static String toJson(Object message) throws JsonProcessingException {
     }
 
     public static <T> T fromJson(String body) throws IOException {
-        return mapper.readValue(body, new TypeReference<List<LambdaFunction>>(){});
+        return (T) mapper.readValue(body, new TypeReference<List<LambdaFunction>>(){});
     }
 }