Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo-warp example broken #173

Closed
kellpossible opened this issue Jun 16, 2022 · 3 comments · Fixed by #174
Closed

todo-warp example broken #173

kellpossible opened this issue Jun 16, 2022 · 3 comments · Fixed by #174

Comments

@kellpossible
Copy link
Contributor

The todo-warp example is currently broken, it shows an empty page on both the http://localhost:8080/swagger-ui/ and http://localhost:8080/swagger-ui paths. Perhaps this is related to #171 ? Checking out the previous commit 13c9149, the example runs successfully.
@kellpossible
Copy link
Contributor Author

Nevermind it might be something more recent, 39c1a50 also works...

@kellpossible
Copy link
Contributor Author

Okay it looks like commit 37b616d broke it

@kellpossible kellpossible mentioned this issue Jun 16, 2022
Merged
4 tasks
kellpossible added a commit to kellpossible/utoipa that referenced this issue Jun 16, 2022
@kellpossible
Fix From implementation for Config, which fixes juhaku#173
75bfe9d
@kellpossible kellpossible mentioned this issue Jun 16, 2022
Merged
juhaku pushed a commit that referenced this issue Jun 16, 2022
@kellpossible
Fix From implementation for Config, which fixes #173 (#174)
c8d1a26
@juhaku
Copy link
Owner

juhaku commented Jun 16, 2022

Yeah I broke it yesteday, and simultaneously I broke all the other examples. The current swagger config management needs some care and I address it today later on. And check the rest of the PR's as well.

juhaku added a commit that referenced this issue Jun 18, 2022
@kellpossible @juhaku
Parameters as struct implementing IntoParams for warp (and other fram…
4b8435b 
…eworks) (#150)

* Support accepting `params(Type)` for `path` where `Type` implements `IntoParams`, closing #129.
* Modified `todo-warp` to show this feature in use.
* Implement #151 container attributes for `IntoParams` including `style` and `parameter_in`. For example: `#[param(style = Form, parameter_in = Query)]`.
*  Add unit tests with this feature.
* Fix failing tests.
* Allow params in `#[utoipa::path(...)}` to be specified using both struct and bracket style.
* Support paths like in #161
* ~Fix todo-warp project~ edit: looks like this is a regression on `master` #173
* Refactor ParameterIn for manual parameter definitions to use the same
parsing logic, this is a breaking change to use Pascal case for these:
`Path`, `Query`, `Header`, `Cookie`
* Update documentation

This work was sponsored by [Arctoris](https://www.arctoris.com/).

Co-authored-by: Juha Kukkonen <juha7kukkonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix From implementation for Config kellpossible/utoipa
2 participants
@kellpossible @juhaku