Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos to CI #1036

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Add typos to CI #1036

merged 3 commits into from
Sep 9, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 9, 2024

Please merge #1038 first

name: typos
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? Does it throw error if it finds typos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is configurable if there are false positives

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I guess we can have it.

@juhaku juhaku merged commit 9d778b0 into juhaku:master Sep 9, 2024
10 checks passed
@jayvdb jayvdb deleted the typos branch September 9, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants