Chore unify request body and ext request body #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unifies to logic for parsed request body and ext request body from handler function argument. Prior to this commit they had separate implementations for `ToTokens` but that is changed in this commit for being overly superfluous and error prone. Now they share same `ToTokens` logic where only difference is how the `ComponentSchema` is resolved for the different types of request bodies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies to logic for parsed request body and ext request body from handler function argument. Prior to this commit they had separate implementations for
ToTokensbut that is changed in this commit for being overly superfluous and error prone. Now they share sameToTokenslogic where only difference is how theComponentSchemais resolved for the different types of request bodies.