Fix as attribute path format
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaku
force-pushed
the
fix-as-path-format
branch
2 times, most recently
from
2156d5a to
d45a869
Compare
Prior to this commit the `as` attribute produced invalid path with line
break within the name and some colons not being replaced. This commit
will fix this where now as definition like following will get serialized
correctly to JSON as shown below.
```rust
#[derive(ToSchema)]
#[schema(as = types::calculation::calculation_assembly_cost::v1::CalculationAssemblyCostResponse)]
pub struct CalculationAssemblyCostResponse {
#[schema(value_type = uuid::Uuid)]
pub id: String,
}
```
Will serialize to:
```json
"schema": {
"$ref": "#/components/schemas/types.calculation.calculation_assembly_cost.v1.CalculationAssemblyCostResponse"
},
```
Fixes #1019
juhaku
force-pushed
the
fix-as-path-format
branch
from
d45a869 to
377e1bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the
asattribute produced invalid path with line break within the name and some colons not being replaced. This commit will fix this where now as definition like following will get serialized correctly to JSON as shown below.Will serialize to:
Fixes #1019