Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic references #1097

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix generic references #1097

merged 1 commit into from
Oct 6, 2024

Conversation

juhaku
Copy link
Owner

@juhaku juhaku commented Oct 6, 2024

This PR is follow up for #1095 which fixed the generic references name resolving. This commit will fix the generic references inner type resolving. Prior this commit the generic reference always set everything as $ref even in case of primitive type. Nonetheless now the correct type will be used instead.

Fixes #1092

This PR is follow up for #1095 which fixed the generic references name
resolving. This commit will fix the generic references inner type
resolving. Prior this commit the generic reference always set everything
as `$ref` even in case of primitive type. Nonetheless now the correct
type will be used instead.
@juhaku juhaku force-pushed the fix-generic-references branch from bbbf3ed to 880d84f Compare October 6, 2024 13:08
@juhaku juhaku merged commit 8f95e1c into master Oct 6, 2024
22 checks passed
@juhaku juhaku deleted the fix-generic-references branch October 6, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

[5.0.0-rc.0] Deeply nested generics (>=2 levels) generates incorrect schemas
1 participant