Chore enhance generic schema collection #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaku
force-pushed
the
chore-schema-collect-fix
branch
from
c9c1fd0 to
1e00932
Compare
This commit enhances generic schema collection from generic arguments for pre defined set of container types. Prior to this commit if the generic argument was one of known container types like `Vec` or `LinkedList` then types within that container type was not correctly composed. This commit addresses this allowing better compose ability. This commit changes the auto collect of schemas to only collect non inlined schemas from their usage. This results leaner OpenAPI document by avoid polluting the OpenAPI document from unrelated schemas (which are not used by referencing). This behavior can be altered with `utoipa-config` by setting `SchemaCollect::All` mode on which will return to old behavior of collecting also inlined schemas. Closes #1114
juhaku
force-pushed
the
chore-schema-collect-fix
branch
from
1e00932 to
1dc9cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances generic schema collection from generic arguments for pre defined set of container types. Prior to this commit if the generic argument was one of known container types like
VecorLinkedListthen types within that container type was not correctly composed. This commit addresses this allowing better compose ability.This commit changes the auto collect of schemas to only collect non inlined schemas from their usage. This results leaner OpenAPI document by avoid polluting the OpenAPI document from unrelated schemas (which are not used by referencing). This behavior can be altered with
utoipa-configby settingSchemaCollect::Allmode on which will return to old behavior of collecting also inlined schemas.Closes #1114