Add Rocket IntoParams and generalize ext args #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaku
force-pushed
the
feature-from-form-rocket
branch
from
32770a9 to
bc5fef2
Compare
Add Rocket IntoParams implementation for `FromForm` trait and refactor Rocket extensions. Refactor all extension modules to use general `TypeTree` type for arguments and generalize implementations. Clean up the extension implementations and deprecate `ComponentPart` type in favor of new `TypeTree` type which handles maps and tuples correctly. Further PR:s should address moving to the new `TypeTree`.
juhaku
force-pushed
the
feature-from-form-rocket
branch
2 times, most recently
from
008baa2 to
42094e0
Compare
juhaku
force-pushed
the
feature-from-form-rocket
branch
from
42094e0 to
7925f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Rocket IntoParams implementation for
FromFormtrait and refactorRocket extensions.
Refactor all extension modules to use general
TypeTreetype forarguments and generalize implementations. Clean up the extension
implementations and deprecate
ComponentParttype in favor of newTypeTreetype which handles maps and tuples correctly. Further PR:sshould address moving to the new
TypeTree.Implements #222