Refactor enums #289
Merged
Refactor enums #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor enum implemenation by keeping things DRY. This PR adds
better foundation over furhter development of features concerning enums.
Aslo remove the limitation of not allowing
schemaattribute to be used ononeOfcomplex enum type. This allows defining ofdefaultandexampleattribute over complex enum via
schemaattribute ofToSchemaderive macro.The enum refactoring is not complete but this PR will be first one in the serie of
coming improvements and new features.
relates to #285