New component attribute parsing #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing over the actual PR: #334 |
juhaku
added a commit
that referenced
this pull request
Nov 3, 2022
This PR will add a new implementation of a new component attribute parsing functionality. The current one residing in `attr.rs` is far too limited and static for the purpose of attribute parsing since there actually is a need to combine different set of attributes based on different cases in more dynamic manner. This also makes adding new component attributes far easier and quicker as requisites evolve over time. The original `attr.rs` should be phased out eventually when all it's referrers have been migrated to the new implementation. Currently there is `IntoParams` derive macro which is still using the old implementation. Additionally to new component attribute parsing logic added this PR will fix couple of bugs regarding attribute parsing. One which is referenced below where Vec example was not redered correctly under array type itself in the generated OpenAPI doc. Another bug did not allow and did not render correctly xml attributes for Option Vec fields of structs decorated with `ToSchema` derive macro. Fixes #225, resolves #331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP implementation of new component attribute parsing functionality. The current one residing in
attr.rsis far too limited and static for the purpose of attribute parsing since there actually is a need to combine different set of attributes based on different cases in more dynamic manner.Fixes #225