Fix nullable ref schema #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for correct $ref schema nullable fields.
Optioal type field e.g. `book: Option<Book>` will be rendered as nullable
allOf field so client side generators can create correct client and types
from the generated openapi.json.
```json
"book": {
"nullable": true,
"allOf": [
{
"$ref": "#/components/schemas/Book"
}
]
}
```
joaommartins
added a commit
to franklin-ai/utoipa
that referenced
this pull request
Mar 10, 2023
This commit adds support for correct $ref schema nullable fields.
Optioal type field e.g. `book: Option<Book>` will be rendered as nullable
allOf field so client side generators can create correct client and types
from the generated openapi.json.
```json
"book": {
"nullable": true,
"allOf": [
{
"$ref": "#/components/schemas/Book"
}
]
}
```
Co-authored-by: Juha Kukkonen <juha7kukkonen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for correct $ref schema nullable fields. Optioal type field e.g.
book: Option<Book>will be rendered as nullable allOf field so client side generators can create correct client and types from the generated openapi.json.Fixes #314