This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
Reverting nginx 1.12 changes until https://github.com/kubernetes/kube… #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsakalozos
reviewed
Nov 1, 2018
| 's390x': 'quay.io/kubernetes-ingress-controller/nginx-ingress-controller-s390x:0.19.0', # noqa | ||
| 'ppc64el': 'quay.io/kubernetes-ingress-controller/nginx-ingress-controller-ppc64le:0.19.0', # noqa | ||
| images = {'amd64': 'quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.16.1', # noqa | ||
| 'arm64': 'quay.io/kubernetes-ingress-controller/nginx-ingress-controller-arm64:0.16.1', # noqa |
There was a problem hiding this comment.
I think this ingress controller will not work for arm. Have a look at this comment: kubernetes/ingress-nginx#3214 (review) pointing to this bug kubernetes/ingress-nginx#2802 . On microk8s+arm64 I had to revert all the way to tag "0.11.0"
There was a problem hiding this comment.
Good to know, thanks. I think we can safely ignore that concern in this PR though.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Reverting the nginx bump until kubernetes#70044 is resolved. This bug prevents ingress from coming online after a charm upgrade because the old nginx pods get stuck terminating and hold the ports hostage.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: