Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing build packages #638

Closed
fnordahl opened this issue Sep 29, 2022 · 0 comments · Fixed by #639
Closed

Missing build packages #638

fnordahl opened this issue Sep 29, 2022 · 0 comments · Fixed by #639

Comments

@fnordahl
Copy link
Collaborator

The change of default for using Python and associated tools from the build environment introduced in commit 2482f0f and commit 725d2cb are correct and required for delegating buid-on / run-on decisions to charmcraft.

However, they also introduce a regression on the form of missing build-packages.

Adding the following to a charmcraft.yaml solves it:

    build-packages:
      - virtualenv
      - git

However at this point in time there may be a large estate of charms that currently do not define this.

Furthermore the charmcraft reactive plugin most likely should declare these build-packages as bare minimum default anyway.

Perhaps we need to workaround this issue?

fnordahl added a commit to fnordahl/charm-tools that referenced this issue Sep 29, 2022
The bare minimum of build packages may be missing following
commit 2482f0f and commit 725d2cb.

While the resolution may belong in charmcraft, we need a
workaround.

Fixes juju#638
fnordahl added a commit that referenced this issue Sep 29, 2022
The bare minimum of build packages may be missing following
commit 2482f0f and commit 725d2cb.

While the resolution may belong in charmcraft, we need a
workaround.

Fixes #638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant