Fix non x86 builds of charm-tools itself #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the dependency pin set so that dependencies can be consumed from versions from the Ubuntu distribution wherever possible.
Update snap recipe so that building charm-tools itself succeeds on non-x86 architectures. With reproducibility and maintainability of the snap in mind, make use of Python dependencies from Ubuntu distribution packages wherever possible. For any dependencies not available in the Ubuntu distribution, we request a build from source as this will ensure that build-package requirements are uncovered at a early stage in the development process, preferably already in the gate check. Drop the PYTHON related build-environment variables as these would mandate installing all build dependencies in the snap, which is not what we want. Instead reference these variables when needed in the build recipe.
|
Binary artifacts available for review in the Build logs per architecture: |
ajkavanagh
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit.
setup: Update charm-tools pin set
consumed from versions from the Ubuntu distribution wherever
possible.
snap: Ensure build succeeds on non-x86 architectures
Update snap recipe so that building charm-tools itself succeeds on non-x86 architectures.
With reproducibility and maintainability of the snap in mind, make use of Python dependencies from Ubuntu distribution packages wherever possible.
For any dependencies not available in the Ubuntu distribution, we request a build from source as this will ensure that build-package requirements are uncovered at a early stage in the development process, preferably already in the gate check.
Drop the PYTHON related build-environment variables as these would mandate installing all build dependencies in the snap, which is not what we want. Instead reference these variables when needed in the build recipe.