Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test coverage for pull-sources #629

Merged
merged 1 commit into from
Sep 20, 2022
Merged

add unit test coverage for pull-sources #629

merged 1 commit into from
Sep 20, 2022

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Sep 19, 2022 •
edited
Loading

  • Adds unit test coverage for pull sources
  • Provides reasoning as to why a fetch error has occurred

Checklist

  • Are all your commits [logically] grouped and squashed appropriately?
  • Does this patch have code coverage?
  • Does your code pass make test?

fnordahl
fnordahl approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@fnordahl fnordahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fnordahl fnordahl merged commit 8e87b27 into juju:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnordahl fnordahl fnordahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @fnordahl