Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version output to be compatbile with sibling projects #637

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

fnordahl
Copy link
Collaborator

Due to how some other projects parse our version string the current format may break people.

Fixes #636

Due to how some other projects parse our version string the
current format may break people.

Fixes juju#636
Copy link
Contributor

@freyes freyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all the reasoning described in #636 looks correct to me.

@fnordahl fnordahl merged commit d56d76b into juju:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charm version compatibility output is unfortunately not compatible with charmcraft 2.0
2 participants