Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charmcraft integration test #645

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

fnordahl
Copy link
Collaborator

@fnordahl fnordahl commented Oct 9, 2022

Please review commit by commit

The fix in eb03bc1 calls `subprocess.run` with an empty
dict as environment to escape snap environment when installing
packages on the host system.  This does unfortunately not work in
all circumstances.

Fixes juju#644
Colocate all jobs in a single file in order to make use of job
dependencies.

Inject a fake git tag in the snap build job so that valid version
information is provided in the build.  Attempts to adjust
fetch-depth or direct calls to `git fetch --tags` was
unsuccessful.  The charmcraft reactive plugin validates this
information later in the integration test.

Add integration test that builds a minimal reactive charm using
charmcraft and the reactive plugin.
@fnordahl fnordahl force-pushed the add-charmcraft-integration-test branch from f7e35cb to 6309d6a Compare October 9, 2022 19:54
@fnordahl fnordahl merged commit 30534c8 into juju:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant