Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github workflow to include a noble build on charmcraft-2.x #676

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update github workflow to include a noble build on charmcraft-2.x #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637e2b6
Update github workflow to include a noble build on charmcraft-2.x
addyess Jul 31, 2024
1703324
uniqify the artifact names
addyess Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ jobs:
- '3.12' # noble
steps:
- name: Check out code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install Tox
Expand All @@ -31,12 +31,12 @@ jobs:
needs: unit
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Add fake tag to make vergit happy
run: git tag v0.0.0
- uses: snapcore/action-build@v1
id: snap-build
- uses: actions/upload-artifact@v1
- uses: actions/upload-artifact@v4
with:
name: charm-snap
path: ${{ steps.snap-build.outputs.snap }}
Expand All @@ -62,12 +62,12 @@ jobs:
sudo iptables -F FORWARD
sudo iptables -P FORWARD ACCEPT
- name: Checkout layer-basic
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
repository: juju-solutions/layer-basic

- name: Download built charm snap
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: charm-snap
path: tests/charm-minimal/charm-snap
Expand Down Expand Up @@ -107,6 +107,9 @@ jobs:
- name: ubuntu
channel: "22.04"
architectures: [amd64]
- name: ubuntu
channel: "24.04"
architectures: [amd64]
Comment on lines +110 to +112
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds a noble base to try out.

EOF
charmcraft pack -p tests/charm-minimal -v
- name: Build reactive charm with charmcraft-3.x
Expand Down Expand Up @@ -146,16 +149,12 @@ jobs:
# uses: lhotari/action-upterm@v1
- name: Upload charmcraft execution logs
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: charmcraft execution logs
path: ~/snap/charmcraft/common/cache/charmcraft/log/*.log
- name: Upload built charms
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Built charms
path: |
minimal_ubuntu-18.04-amd64.charm
minimal_ubuntu-20.04-amd64.charm
minimal_ubuntu-22.04-amd64.charm
minimal_ubuntu-24.04-amd64.charm
name: ${{matrix.charmcraft_channel}} built charms
path: minimal_ubuntu-*-amd64.charm