-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JUJU-759] Change error types to use new ConstError #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
barrettj12
changed the title
Change error types to use new ConstError
[JUJU-759] Change error types to use new ConstError
Mar 22, 2022
!!build!! |
tlm
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wallyworld
reviewed
Mar 23, 2022
hpidcock
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nagging question.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #52, this library now supports
errors.Is
,errors.As
, anderrors.Unwrap
from Go's standard errors library. This PR changes theIsX
functions fromerrortypes.go
to useerrors.Is
under the hood:ConstError
, whose values are "sentinel errors" representing a certain error type.errWithType
, which is anErr
bundled with its error typeerrType ConstError
.errWithType
implements anIs
method that compares its argument toerrType
. This ensures e.g.Is(e, NotFound)
works as expected.timeout
,notFound
have been replaced witherrWithType
.X ConstError
,Xf
andNewX
now returne errWithType
wheree.errType
isX
.IsX
functions are now implemented by comparison toX
.This is structurally quite a big change, but the errors should behave exactly as before (all the tests in
errortypes_test.go
pass).