[JUJU-1339] Adds a shush method to the library and IsType. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrettj12
reviewed
Jun 19, 2022
|
/build |
2 similar comments
|
/build |
|
/build |
wallyworld
approved these changes
Jun 20, 2022
tlm
force-pushed
the
shush-errors
branch
2 times, most recently
from
238bd8e
to
83c1c25
Compare
tlm
changed the title
wallyworld
approved these changes
Jun 21, 2022
Hide is responsible for making an error silent in fmt output. Specifically useful with fmt.Errorf when you want an error to be wrapped but want it's error message shushed. IsType is a convenience method for checking a more complex error is of type x within it's change. This is for cases where errors.Is can't be used and where errors.As is not needed for the actual error type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shush is responsible for making an error silent in fmt output.
Specifically useful with fmt.Errorf when you want an error to be wrapped
but want its error message shushed.
IsType is a convenience method for checking a more complex error is of
type x within it's change. This is for cases where errors.Is can't be
used and where errors.As is not needed for the actual error type.