Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken build options #32

Merged
merged 6 commits into from
Jul 24, 2022
Merged

Remove broken build options #32

merged 6 commits into from
Jul 24, 2022

Conversation

AJenbo
Copy link

@AJenbo AJenbo commented Jun 24, 2022

Sad to see that support for non-Windows was broken to save 0.1% lines of code #5

Might as well remove all of it since it's none functional at this point. So much for your complaints about not supporting OSs that the developers don't use I guess.

@AJenbo AJenbo mentioned this pull request Jul 12, 2022
@julealgon
Copy link
Owner

Sad to see that support for non-Windows was broken to save 0.1% lines of code #5

I think you are just missing the bigger picture on this. None of this code will remain as is (certainly not cmake) as I make the move to C#. I was just trying to trim as much as I could to remove anything out of the way for the migration. I didn't know upfront how many lines of code each of those things would really be, and that's a secondary concern really.

Might as well remove all of it since it's none functional at this point.

Only reason I didn't remove this was because I didn't know 100% if I could. I appreciate you doing it.

So much for your complaints about not supporting OSs that the developers don't use I guess.

I'm not quite sure what you mean here.

@julealgon julealgon merged commit 943996e into julealgon:master Jul 24, 2022
@AJenbo AJenbo deleted the patch-5 branch July 24, 2022 17:38
@AJenbo
Copy link
Author

AJenbo commented Jul 24, 2022

Glad you like the cleanup :)

I'm not quite sure what you mean here.

I just remember you complaining that Linux developers don't go out of there way to support Windows. So it seamed ironic that you actively removing Linux support.

I don't think I'm missing the big picture, just being pessimistic. But hey, maybe this will end up as the first C# application I encounter with enough build instructions that I can actually run it outside of Windows :D

@julealgon
Copy link
Owner

I just remember you complaining that Linux developers don't go out of there way to support Windows. So it seamed ironic that you actively removing Linux support.

Well currently, I'm not going out of my way to support anything in the C++ stack really 😆 I'm completely ignorant on cmake, so I just wanted to minimize noise as much as I could so that whatever remained was easier for me to parse for the conversion later.

I don't think I'm missing the big picture, just being pessimistic. But hey, maybe this will end up as the first C# application I encounter with enough build instructions that I can actually run it outside of Windows :D

Hopefully that should be the case. I'm looking into using the Monogame engine for the C# version (doing a few tests with it at the moment), and that is portable.

C# has been portable for several years at this point so it surprises me that you've had such bad luck in finding a portable project created with it.

@AJenbo
Copy link
Author

AJenbo commented Jul 25, 2022

C# has been portable for several years at this point so it surprises me that you've had such bad luck in finding a portable project created with it.

I'm aware, C# proponents keeps telling me. But so fare no one I have med have actually used it or know how to set it up since they all just use Windows. I haven't looked in to it myself either, all I have concluded is that it isn't as simple as downloading Visual Code and clicking build which is what I was told by someone that never tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants